search

The-OpenROAD-Project / OpenDB

Database and Tool Framework for EDA
BSD 3-Clause "New" or "Revised" License
103 stars 42 forks source link

remove unnecessary ifs #105

Closed maliberty closed 4 years ago

maliberty commented 4 years ago

Would someone approve or comment?

abdelrahmanhosny commented 4 years ago

I think these were added because RePlAce had a tight integration where targets were added twice if OpenDB was built from an outside application (i.e. RePlAce). It would make sense to remove them now, but safer to double check with @jjcherry56 that this will not break OpenROAD build (because a target gets built twice)

jjcherry56 commented 4 years ago

There is nothing in openroad itself that requires them and any tool that tries to build them itself has a broken cmake file that needs to be fixed. Replace uses a separate branch for the stand alone application to avoid this issue.

On Sun, Jan 12, 2020 at 7:09 AM Abdelrahman notifications@github.com wrote:

I think these were added because RePlAce had a tight integration and targets were added twice if OpenDB was build from an outside application. It would make sense to remove them now, but safer to double check with @jjcherry56 https://github.com/jjcherry56 that this will not break OpenROAD build (because a target gets built twice)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/The-OpenROAD-Project/OpenDB/pull/105?email_source=notifications&email_token=AIJDZFIISCY2BELMBW2M7ETQ5MQAJA5CNFSM4KE35OB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW22UI#issuecomment-573418833, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJDZFOMGPQOVTDIJORB653Q5MQAJANCNFSM4KE35OBQ .

maliberty commented 4 years ago

So can I get an approval?