The-OpenROAD-Project / OpenDB

Database and Tool Framework for EDA
BSD 3-Clause "New" or "Revised" License
103 stars 42 forks source link

Add find_package(spdlog) in CMakeLists #138

Closed sheiny closed 3 years ago

sheiny commented 3 years ago

-This commit adds the find_package(spdlog) which was missing in CMakeLists.txt according to issue #137: https://github.com/sheiny/OpenDB/blob/e0e98c4ab23094184598fa579d51ff2d1b897569/CMakeLists.txt#L18

-It also includes the #include in lefout.h, since the PR from issue #134 was not merged yet. Otherwise, I would not be able to build the code on my machine. https://github.com/sheiny/OpenDB/blob/e0e98c4ab23094184598fa579d51ff2d1b897569/include/opendb/lefout.h#L36

Please let me know if you need more information.

Thanks, Sheiny

osamahammad21 commented 3 years ago

@sheiny find_package(spdlog) is not missing. It is in the CMakeLists.txt under src/db/ directory.

sheiny commented 3 years ago

Hi, thank you for your reply. You're completely right. I'm sorry, I just realized that I made a mistake in my fork, so I'm closing this PR.