The-OpenROAD-Project / OpenLane

OpenLane is an automated RTL to GDSII flow based on several components including OpenROAD, Yosys, Magic, Netgen and custom methodology scripts for design exploration and optimization.
https://openlane.readthedocs.io/
Apache License 2.0
1.32k stars 372 forks source link

erroneous message about obstruction co-ordinates #1199

Closed mattvenn closed 1 year ago

mattvenn commented 2 years ago

I am setting an obstruction over openram so it can be routed to without causing DRC errors.

set ::env(GLB_RT_OBS)  "li1  0    0   2920    3520,
       met1 344.0 475.5 823.78 873.0,
       met2 344.0 475.5 823.78 873.0,
       met3 344.0 475.5 823.78 873.0,
       met4 344.0 475.5 823.78 873.0"

These are lower left and upper right co-ordinates.

Then when I run the flow I get this warning message:

[WARNING]: Specifying a routing obstruction is now done using the coordinates
[WARNING]: of its bounding box instead of the now deprecated (x, y, size_x, size_y).
[INFO]: Obstructions added over li1  0    0   2920    3520,
       met1 344.0 475.5 823.78 873.0,
       met2 344.0 475.5 823.78 873.0,
       met3 344.0 475.5 823.78 873.0,
       met4 344.0 475.5 823.78 873.0.

The message is erroneous because I'm already using co-ords of lower left and top right corners as per the docs.

vijayank88 commented 2 years ago

@mattvenn While changing GLB_RT_OBS configuration, for time being they just wants to print WARNING message to aware of change in co-ordinates format.

In future that message will be removed. Maybe @donn know how long it will take to remove.

donn commented 2 years ago

It should be gone by now, yeah, I'll open a PR

kareefardi commented 1 year ago

Fixed in https://github.com/The-OpenROAD-Project/OpenLane/pull/1244