search

The-OpenROAD-Project / OpenLane

OpenLane is an automated RTL to GDSII flow based on several components including OpenROAD, Yosys, Magic, Netgen and custom methodology scripts for design exploration and optimization.
https://openlane.readthedocs.io/
Apache License 2.0
1.25k stars 365 forks source link

Request to Bump Yosys (downgrade) to 0.33+6 (git sha1 41b34a193) #2050

Closed dlmiles closed 7 months ago

dlmiles commented 7 months ago

Description

Please consider revising the recent closed PR #2027 (Bump Yosys) back a few weeks to:

Yosys 0.33+6 (git sha1 41b34a193, clang 10.0.0-4ubuntu1 -fPIC -Os)

Due to flow issues concerning:

https://github.com/YosysHQ/yosys/issues/4039

Please feel free to close this issue once you have considered the situation and made a verdict no matter the outcome, I provide this issue to advise of on-going matter.

Thanks

Expected Behavior

yosys-abc Assertion triggered after processing a significant number of designs (estimated worse than 3%)

Assertion causes STEP1 to fail due to abort/core-dump like crash, exit status 134

Environment report

Linux OpenLane docker

Reproduction material

See linked Yosys issue for test case and log outputs.

Relevant log output

See linked Yosys issue for test case and log outputs.

kareefardi commented 7 months ago

@dlmiles Just to confirm. Downgrading fixes the crash. In addition, using the new commands in #2051 also fixes the crash ?

dlmiles commented 7 months ago

@dlmiles Just to confirm. Downgrading fixes the crash. In addition, using the new commands in #2051 also fixes the crash ?

Yes that is correct

Note I tested locally with a slightly newer Yosys (their latest tag), but I believe the OL CI has just run successfully with the 0.34 (git sha1 4a1b5599258) which is the latest Bump Yosys at this time.

My local testing build ran with the patch from #2051 and this only other change:

diff --git a/dependencies/tool_metadata.yml b/dependencies/tool_metadata.yml
index 9d596daa..0034d040 100644
--- a/dependencies/tool_metadata.yml
+++ b/dependencies/tool_metadata.yml
@@ -44,7 +44,7 @@
     make install
 - name: yosys
   repo: https://github.com/YosysHQ/yosys
-  commit: 4a1b5599258881f579a2d95274754bcd8fc171bd
+  commit: cc31c6ebc450f0dfe991663376c4e0b94944188b
   build: |
     make clean
     make PREFIX=$PREFIX config-gcc

for Yosys 0.35 (git sha1 cc31c6ebc45, gcc 8.3.1 -fPIC -Os)

donn commented 7 months ago

Sorry, I don't think we'll be downgrading- for OpenLane 1 it may be doable, for OpenLane 2 we have a number of plugins that rely on this newer version of Yosys, including eqy, verible, lighter… And we do keep the tool versions synchronized for now.

I've reported the true issue in isolation in #2052.