The-OpenROAD-Project / OpenLane

OpenLane is an automated RTL to GDSII flow based on several components including OpenROAD, Yosys, Magic, Netgen and custom methodology scripts for design exploration and optimization.
https://openlane.readthedocs.io/
Apache License 2.0
1.25k stars 365 forks source link

Flow runtime should only have exit status 0 for success when SUCCESS was achieved #2110

Closed dlmiles closed 2 months ago

dlmiles commented 2 months ago

Description

Please consider amending what looks to be this line https://github.com/The-OpenROAD-Project/OpenLane/blob/master/scripts/utils/utils.tcl#L749 to exit the container with non-zero exit status code (maybe a special number such as 255 the max code to make it distinct from anything else to indicate an issue reproducible exists and the flow failed).

The exit status of 0 should be reserved for circumstances in which the flow "SUCCESS" was achieved as a minimum observed requirement.

At this time to the outside world the container can look like it was successful when it was not.

Expected Behavior

When using the flow container runtime, when it exits with a status of zero that should mean it achieved SUCCESS state in the last STEP. So the superior process exits indicate success with the main task.

Environment report

Affects all versions since issue reproducible was added.

Reproduction material

N/A

Relevant log output

N/A