search

The-OpenROAD-Project / OpenLane

OpenLane is an automated RTL to GDSII flow based on several components including OpenROAD, Yosys, Magic, Netgen and custom methodology scripts for design exploration and optimization.
https://openlane.readthedocs.io/
Apache License 2.0
1.36k stars 376 forks source link

bugfix: Replaced inappropriate `is` comparison with `==` #2157

Closed fazledyn closed 1 month ago

fazledyn commented 1 month ago

Introduction

This PR fixes a logical bug in your codebase

Description

In file gui.py, there's a comparison that compares an empty list to an object using is operator. This is not the correct way to compare objects with empty list or dict.

For example, running the code below will give the output:

x = []
print(x is [])
False

As a result, it's better to perform comparison using == operator than is.

Contribution

All contributions made in this PR follows Developer Certificate of Origin

Comments

If you think such fixes aren't necessary for your project, and you'd like me to find some better bugs / code-to-fix, then please let me know. I'll be happy to contribute.

donn commented 1 month ago

No, this is super helpful. I'm left wondering why the linter didn't catch that.

Thank you.