Open luarss opened 3 months ago
It appears this design is not running in the CI.
Should we remove the autotuner.json
file for this design then? Since the default flow is not working.
Probably we should just get the base case working or remove the whole design. Can the autotuner find a working configuration?
@povik this appears to be an yosys-abc crash. Should that be reported to yosyshq or directly to abc?
If I run yosys-abc myself I see
yosys-abc: src/map/scl/sclBufSize.c:388: abc::Abc_Obj_t* abc::Abc_SclAddOneInv(abc::Bus_Man_t*, abc::Abc_Obj_t*, abc::Vec_Ptr_t*, float): Assertion `LoadNew - Load < 1 && Load - LoadNew < 1' failed.
Aborted (core dumped)
Hah, just the other way I was looking at the buffering code and noting those assertions don't make such sense (the units there are such that 1 shouldn't be a special value), so I suspect the fix is to simply remove those.
Generally I think one has better chances with opening a Yosys issue than reporting it to the upstream abc project. Here though the issue can be pointed out easily so maybe an abc report would work too. We carry some downstream patches for abc issues and the prospect of getting those mainline are uncertain.
@povik if you are planning to look at it I could just assign this issue to you or I could transfer it to yosyshq.
It's not something I was planning to look at, but feel free to assign it to me, I just don't know when I will get to it. When I do, I can confirm removing the assertions does the trick (and double-check the assertions are nonsensical).
@QuantamHD FYI in case Alan wants to look at this directly.
Alan won't fix any bugs for you, but if you open PRs we can email him to get him to review.
@povik could you make a PR removing the assertions you believe are wrong?
I confirm the reported bug. Interestingly, abc works as expected when in flow/scripts/abc_speed.script the last lines
buffer -c
topo
stime -c
upsize -c
dnsize -c
be replaced by:
buffer
topo
stime
upsize
dnsize
That could be a clue.
Should that be reported to yosyshq or directly to abc?
From the above findings ('-c' in abc_speed.script) i guess : abc.
Subject
Describe the bug
Flow terminates at yosys synthesis stage.
Expected Behavior
Should not terminate.
Environment
To Reproduce
cd flow && make DESIGN_CONFIG=./designs/ihp-sg13g2/jpeg/config.mk
Relevant log output
Screenshots
No response
Additional Context
No response