search

The-OpenROAD-Project / OpenROAD-flow-scripts

OpenROAD's scripts implementing an RTL-to-GDS Flow. Documentation at https://openroad-flow-scripts.readthedocs.io/en/latest/
https://theopenroadproject.org/
Other
282 stars 262 forks source link

asap7-aes-block: update metrics for mpl2-snapper / point to lastest OR with changes #2036

Closed AcKoucher closed 1 month ago

AcKoucher commented 1 month ago
Metric Old New Type
finishtimingsetup__ws -285.81 -329.84 Failing
finishtimingdrv__hold_violation_count 238 424 Failing
maliberty commented 1 month ago

Is the OR submodule update to a commit on master? It shouldn't be pointed to a branch.

AcKoucher commented 1 month ago

I see. My intentions were to sync master with my changes in #5160 so CI doesn't break. Should I wait for it to be merged so I can point correctly or should this PR be strictly for updating the metrics?

maliberty commented 1 month ago

I see. My intentions were to sync master with my changes in #5160 so CI doesn't break. Should I wait for it to be merged so I can point correctly or should this PR be strictly for updating the metrics?

You should either wait or split updating metrics from updating OR.

maliberty commented 1 month ago

I merged the other so please update this PR

AcKoucher commented 1 month ago

I updated the changes here so that we only update the metrics.