Closed eszpotanski closed 2 months ago
@eszpotanski Does the user have to know about this option or does it do the correct thing by default?
An obscure option that is required to make the build work is not great, better if the option is just there to handle uncommon cases and that the build script works correctly by default.
It is used by default when user follows the instructions from docs: https://openroad-flow-scripts.readthedocs.io/en/latest/user/BuildLocally.html#clone-and-install-dependencies
Why not simply make a wrapper shell script that has all of the args you want to pass? For example if you want to pass to OpenROAD ARG1=1
ARG2=2
ARG3=3
Then just make wrapper.sh
with:
./build_openroadh.sh --openroad-args "ARG1=1 ARG2=2 ARG3=3"
Following the comment, changes were moved to OpenROAD and build_openroad.sh
were adjusted to use Build.sh
from OpenROAD
@vvbandeira Review?
@vvbandeira Review?
Changes are ok, but will need to wait for the OR PR to be merged so we can update the submodule.
@eszpotanski please update the OR submodule. CI needs to be green to move forward.
CI failed due to Jenkins error:
Cannot contact jenkins-worker-central1-fika87: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@5efbd302:jenkins-worker-central1-fika87": Remote call on jenkins-worker-central1-fika87 failed. The channel is closing down or has closed down
Could not connect to jenkins-worker-central1-fika87 to send interrupt signal to process
@vvbandeira can you restart failed jobs?
@eszpotanski You can merge with latest master to trigger a new build...
@maliberty merge? unrelated failure in CI.
Requires https://github.com/The-OpenROAD-Project/OpenROAD/pull/5660
This PR adds option in
build_openroad.sh
script to enable using build arguments from file. This way, additional CMake parameters (from https://github.com/The-OpenROAD-Project/OpenROAD/pull/5660) can be used to make sure the right dependencies' versions are used and prevent errors (e.g. used incompatible version of OR-Tools from system) like: