The-OpenROAD-Project / OpenROAD-flow-scripts

OpenROAD's scripts implementing an RTL-to-GDS Flow. Documentation at https://openroad-flow-scripts.readthedocs.io/en/latest/
https://theopenroadproject.org/
Other
342 stars 290 forks source link

Makefile global route fix #2369

Closed oharboe closed 1 month ago

oharboe commented 1 month ago

@jeffng-or FYI

oharboe commented 1 month ago

@maliberty this is a single commit on top of #2638

maliberty commented 1 month ago

"The Makefile should just handle dependencies, no flow logic." - there are many other places that don't follow this. Loading a large design just to save it out again is a waste of time.

oharboe commented 1 month ago

"The Makefile should just handle dependencies, no flow logic." - there are many other places that don't follow this. Loading a large design just to save it out again is a waste of time.

Granted, but this is a false conflict of goals. Will first identify places, then replace with cp from .tcl.

oharboe commented 1 month ago

"The Makefile should just handle dependencies, no flow logic." - there are many other places that don't follow this. Loading a large design just to save it out again is a waste of time.

Fixed.

oharboe commented 1 month ago

@maliberty Tested locally:

$ make FILL_CELLS= do-5_3_fillcell && stat -c %y  results/nangate45/gcd/base/5_3_fillcell.odb 
Running fillcell.tcl, stage 5_3_fillcell
[INFO ORD-0030] Using 20 thread(s).
exec cp ./results/nangate45/gcd/base/5_2_route.odb ./results/nangate45/gcd/base/5_3_fillcell.odb
Elapsed time: 0:00.05[h:]min:sec. CPU time: user 0.03 sys 0.01 (100%). Peak memory: 99868KB.
2024-09-23 20:48:06.293416973 +0200
$ make do-5_3_fillcell && stat -c %y  results/nangate45/gcd/base/5_3_fillcell.odb 
Running fillcell.tcl, stage 5_3_fillcell
[INFO ORD-0030] Using 20 thread(s).
[INFO DPL-0001] Placed 311 filler instances.
Elapsed time: 0:00.17[h:]min:sec. CPU time: user 0.14 sys 0.03 (99%). Peak memory: 121356KB.
2024-09-23 20:48:14.947617820 +0200
oharboe commented 1 month ago

@maliberty did a force push to fix gaffe in most recent commit

oharboe commented 1 month ago

@maliberty CI error previously, merged with master. This triggers a fresh build and makes it clear that this PR is only a single commit.

oharboe commented 1 month ago

@maliberty CI snafu