search

The-OpenROAD-Project / OpenROAD-flow-scripts

OpenROAD's scripts implementing an RTL-to-GDS Flow. Documentation at https://openroad-flow-scripts.readthedocs.io/en/latest/
https://theopenroadproject.org/
Other
342 stars 290 forks source link

Autotuner: Make flow variable detection more robust #2401

Open maliberty opened 1 month ago

maliberty commented 1 month ago

Subject

[Stage]: Other. Please describe below.

Describe the bug

In https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/2397 the check

            if key not in flow_variables:
                print(f"[ERROR TUN-0017] Variable {key} is not tunable.")
                sys.exit(1)

was disabled due to robustness issues.

Expected Behavior

Do not try to parse the tcl files directly and use a more generic mechanism to get the flow variables. https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/2393 might be relevant.

Environment

As above.

To Reproduce

Use the latest ORFS with the commented section of code re-enabled.

Relevant log output

No response

Screenshots

No response

Additional Context

No response