Improved undo

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[openroadie]

@maliberty The new code is not yet enabled since I need to add better statistics (it will also enable us to correctly count number of moves made vs. number of moves that were rejected/undone) but I would like this PR merged so it does not become an unmanageable mess. The next steps are:

• Add the missing corner cases/more thorough testing
• Once ORFS and maybe even secure ORFS successfully passes, we can move to the new undo method
• Delete the existing undo code if there are no issues

The ORFS test PR (not to be merged) is here.

https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/1482

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[openroadie]

@maliberty This is finally ready. The next step would be to do some testing of the new undo mode and then migrate to it (and delete all the existing undo code). The big difference between new/old Undo is that the new code actually does use a stack (instead of the old ad hoc approach where certain undo operations can simply not be supported).

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[maliberty]

I went ahead and started a secure CI

[openroadie]

Thank you @maliberty . Much appreciated.

[maliberty]

aes/ng45: Error: cts.tcl, 111 ERROR: A problem occurred during equivalence check. aes_lvt/asap7: [ERROR] finishtimingwns_percent_delay fail test: -12.204497 >= -10.0

The first needs investigating but the second could be updated.

[openroadie]

aes/ng45: Error: cts.tcl, 111 ERROR: A problem occurred during equivalence check. aes_lvt/asap7: [ERROR] finishtimingwns_percent_delay fail test: -12.204497 >= -10.0

The first needs investigating but the second could be updated.

Thank you @maliberty . I agree with you and luckily can run aes/n45 locally. I will investigate and report back. Sorry for the delay in replying (been kinda sick this week).

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"