search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.38k stars 485 forks source link

Secure cts tech char2 #4284

Closed openroad-robot closed 6 months ago

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

precisionmoon commented 6 months ago

@maliberty, CI tests are in progress. I manually ran some secure CI tests (aes and gcd), so the QoR should be OK now.

maliberty commented 6 months ago

@eder-matheus please review as I'm getting too backed up

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

eder-matheus commented 6 months ago

@precisionmoon One of the regression tests is failing: aes_nangate45 (tcl) *FAIL* RSZ::hold_buffer_count 128 > 97 Is it expected? Also, do you have a secure CI for this PR? If so, please share the secure branch name with me.

precisionmoon commented 6 months ago

@precisionmoon One of the regression tests is failing: aes_nangate45 (tcl) *FAIL* RSZ::hold_buffer_count 128 > 97 Is it expected? Also, do you have a secure CI for this PR? If so, please share the secure branch name with me.

I don't know why my check-in is causing this. The branch name is secure-cts-tech-char2. I'm seeing a couple of failures in CI tests.

eder-matheus commented 6 months ago

I don't know why my check-in is causing this. The branch name is secure-cts-tech-char2. I'm seeing a couple of failures in CI tests.

@precisionmoon You can run the regression test that is failing locally. Go to OpenROAD/test, and run regression aes_nangate45. The result files will be stored inside OpenROAD/test/results.

About the secure- branch, I didn't find a reference to the name you mentioned on the private ORFS repo.

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

precisionmoon commented 6 months ago

I don't know why my check-in is causing this. The branch name is secure-cts-tech-char2. I'm seeing a couple of failures in CI tests.

@precisionmoon You can run the regression test that is failing locally. Go to OpenROAD/test, and run regression aes_nangate45. The result files will be stored inside OpenROAD/test/results.

About the secure- branch, I didn't find a reference to the name you mentioned on the private ORFS repo.

OR dashboard now shows the results from my latest changes. Commit hash is c5d5063e6d.

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

eder-matheus commented 6 months ago

@precisionmoon Note that this PR has an error in the Mac build pipeline. Could you check if this branch is compiling in your machine? I'll try it on my Mac too.

precisionmoon commented 6 months ago

@precisionmoon Note that this PR has an error in the Mac build pipeline. Could you check if this branch is compiling in your machine? I'll try it on my Mac too.

Sorry, I don't have a mac to try.

eder-matheus commented 6 months ago

@precisionmoon Note that this PR has an error in the Mac build pipeline. Could you check if this branch is compiling in your machine? I'll try it on my Mac too.

Sorry, I don't have a mac to try.

I've tried it on my Mac, and it builds with no errors. Perhaps it is something wrong with ci?

The error is this:

[ 97%] Building CXX object src/cts/src/CMakeFiles/cts_lib.dir/TritonCTS.cpp.o
In file included from /Users/openroad/github-action-runners/actions-runner-0/_work/OpenROAD/OpenROAD/src/cts/src/TritonCTS.cpp:36:
/Users/openroad/github-action-runners/actions-runner-0/_work/OpenROAD/OpenROAD/src/cts/src/../include/cts/TritonCTS.h:187:28: error: implicit instantiation of undefined template 'std::vector<std::string>'
  std::vector<std::string> rootBuffers_;
                           ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/iosfwd:248:28: note: template is declared here
class _LIBCPP_TEMPLATE_VIS vector;
                           ^
In file included from /Users/openroad/github-action-runners/actions-runner-0/_work/OpenROAD/OpenROAD/src/cts/src/TritonCTS.cpp:36:
/Users/openroad/github-action-runners/actions-runner-0/_work/OpenROAD/OpenROAD/src/cts/src/../include/cts/TritonCTS.h:188:28: error: implicit instantiation of undefined template 'std::vector<std::string>'
  std::vector<std::string> sinkBuffers_;
                           ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/iosfwd:248:28: note: template is declared here
class _LIBCPP_TEMPLATE_VIS vector;
precisionmoon commented 6 months ago

@precisionmoon Note that this PR has an error in the Mac build pipeline. Could you check if this branch is compiling in your machine? I'll try it on my Mac too.

Sorry, I don't have a mac to try.

I've tried it on my Mac, and it builds with no errors. Perhaps it is something wrong with ci?

The error is this:

[ 97%] Building CXX object src/cts/src/CMakeFiles/cts_lib.dir/TritonCTS.cpp.o
In file included from /Users/openroad/github-action-runners/actions-runner-0/_work/OpenROAD/OpenROAD/src/cts/src/TritonCTS.cpp:36:
/Users/openroad/github-action-runners/actions-runner-0/_work/OpenROAD/OpenROAD/src/cts/src/../include/cts/TritonCTS.h:187:28: error: implicit instantiation of undefined template 'std::vector<std::string>'
  std::vector<std::string> rootBuffers_;
                           ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/iosfwd:248:28: note: template is declared here
class _LIBCPP_TEMPLATE_VIS vector;
                           ^
In file included from /Users/openroad/github-action-runners/actions-runner-0/_work/OpenROAD/OpenROAD/src/cts/src/TritonCTS.cpp:36:
/Users/openroad/github-action-runners/actions-runner-0/_work/OpenROAD/OpenROAD/src/cts/src/../include/cts/TritonCTS.h:188:28: error: implicit instantiation of undefined template 'std::vector<std::string>'
  std::vector<std::string> sinkBuffers_;
                           ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/iosfwd:248:28: note: template is declared here
class _LIBCPP_TEMPLATE_VIS vector;

I added #include in TritonCTS.cpp. Let's see this resolves the issue. Thanks.

maliberty commented 6 months ago

Looks like TritonCTS.h needs #include <vector>

precisionmoon commented 6 months ago

Looks like TritonCTS.h needs #include <vector>

Yes, this is what I just added.

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

precisionmoon commented 6 months ago

@maliberty , drt/test/ndr_vias2 failure seems unrelated to my changes. My local build can't reproduce this failure.

maliberty commented 6 months ago

Looks like TritonCTS.h needs #include <vector>

Yes, this is what I just added.

I only see it added to TritonCTS.cpp not the .h

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"