Closed luarss closed 2 months ago
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
Cho, answers to the following:
docs/manpages/cat
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
@precisionmoon Ready for review.
For some reason it passes the ibex_sky130hd
CI in pr-head but not pr-merge, so I am not sure if something is wrong with my branch.
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
@maliberty, can Jack's PR be merged?
There are a bunch of conflicts to resolve in the .tcl files
Jack,
Please do the following and resolve merge conflicts.
1) git fetch origin 2) git merge origin/master 3) manually merge conflicts
Thanks.
Cho
On Tue, Feb 20, 2024 at 2:01 PM Matt Liberty @.***> wrote:
There are a bunch of conflicts to resolve in the .tcl files
— Reply to this email directly, view it on GitHub https://github.com/The-OpenROAD-Project/OpenROAD/pull/4543#issuecomment-1955191909, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBVEJRV24ANM5ODHYJBEVH3YUUMLRAVCNFSM6AAAAABB5ICMDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVGE4TCOJQHE . You are receiving this because you were mentioned.Message ID: @.***>
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
@maliberty I have added new changes to local tests above. Would love your feedback. Thanks!
You have a merge conflict to address in src/mpl2/src/mpl.tcl
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
@luarss please resolve the conflict so we can get this merged.
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
@precisionmoon
TODO
Suggestions
-no-pager
;#undocumented
for checker off.