Add in compile flags in splash

[luarss]

Fixes #4550

Output

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[rovinski]

Thanks, @luarss. Please add one more for QtCharts, because it's possible to compile the GUI without charts. Also, please list options alphabetically.

[luarss]

New version

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[rovinski]

GUI after GPU

[oharboe]

Can we modify ORFS so it lists splash screen once?

[luarss]

Updated.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[gadfort]

Would it make sense to make this a single line since it's not that many items? Also should par/mpl2 be on the list since they are conditionally compiled for MacOS?

[maliberty]

Can we modify ORFS so it lists splash screen once?

Each step is a separate run so I think it is best to record it. You could in principle restart the flow at any step with a new build giving a mixed result.

[oharboe]

Can we modify ORFS so it lists splash screen once?

Each step is a separate run so I think it is best to record it. You could in principle restart the flow at any step with a new build giving a mixed result.

While it would be nice to reduce logging noise, idempotency of the steps is a requirement....

Minimally the version is needed in every log. Dumping copyright only to console once would be Ok.

[luarss]

Just to clarify, I see versions.txt recording the OR, yosys and klayout versions already. Do we want something like @echo openroad -splash in ORFS Makefile?

[luarss]

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[maliberty]

I don't feel the copyright is excessive. If we really want to save a line you could be the features after the commit id.

[AcKoucher]

Addresses https://github.com/The-OpenROAD-Project/OpenROAD/issues/4550

@luarss FYI It's better to use one of the special keywords such as "fix" or "resolve" to link the PR with the issue so that when merged the issue will be closed: Linking a PR to an Issue in GH

[maliberty]

fails on mac

[rovinski]

Doesn't this solution feel like overkill? Why does it need a whole CMake generated config file? Can't you just simply use add_definition() or similar and then reference that directly?

[luarss]

@maliberty The error is because we disabled compile definitions for macos in src/CMakeLists.

. Fixing this with an else init.

@rovinski That is a good suggestion. Is there any preference for using add_compile_definitions vs add_definitions?

[rovinski]

@rovinski That is a good suggestion. Is there any preference for using add_compile_definitions vs add_definitions?

Just whichever one works and simplifies the code.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[maliberty]

Doesn't this solution feel like overkill? Why does it need a whole CMake generated config file? Can't you just simply use add_definition() or similar and then reference that directly?

I agree with this. The file generation isn't needed.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[luarss]

@maliberty Updated, now uses less overhead