search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.34k stars 472 forks source link

`DependencyInstaller.sh` touches system files #4923

Open povik opened 3 weeks ago

povik commented 3 weeks ago

Describe the bug

On Ubuntu, DependencyInstaller.sh seems to touch files installed by the system's package manager, even if you go the recommended route of setup.sh from OpenROAD-flow-scripts for a local install. I think it's reasonable to expect any dependency installer script to not do things like that.

Expected Behavior

.

Environment

N/A

To Reproduce

Look into https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/etc/DependencyInstaller.sh#L292 where it stands:

# need the strip "hack" above to run on docker
strip --remove-section=.note.ABI-tag /usr/lib/x86_64-linux-gnu/libQt5Core.so

This runs for any Ubuntu installs, even local ones. This seems to be run from OpenROAD-flow-scripts/setup.sh too.

Relevant log output

No response

Screenshots

No response

Additional Context

No response

vvbandeira commented 3 weeks ago

@habibayassin, could you move this strip command inside the Dockerfile/DockerHelper and make it conditional to run only on Ubuntu?