search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.35k stars 481 forks source link

rudy: avoid heatmap crash #4999

Closed gudeh closed 3 weeks ago

gudeh commented 3 weeks ago

avoid crash when clicking on rudy heatmap and there are unplaced cells.

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

gudeh commented 3 weeks ago

Will the user get any notification as to why the heatmap isn't shown?

It generates the usual "not populated with data". Should it be more specific?

maliberty commented 3 weeks ago

It generates the usual "not populated with data". Should it be more specific?

I think so as it won't be obvious why it isn't populated (which normally happens on demand rather than through an explicit step).

gudeh commented 3 weeks ago

We get the following when trying to activate rudy's heatmap after a make gui_floorplan Screenshot from 2024-04-26 11-34-18

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"