search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.35k stars 482 forks source link

gpl update log messages and README for routability driven mode #5007

Closed gudeh closed 1 week ago

gudeh commented 3 weeks ago

Improve log descriptions to include detailed information about the stages of routability-driven mode. Align log output values for better readability. Add a brief explanation of the routability-driven mode in the readme file.

gudeh commented 3 weeks ago

This modifications should help to address the requests made in issue #4974.

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

rovinski commented 2 weeks ago

As long as you're changing this, can I make a request to print areas in um^2 instead of DBU^2? Perhaps with 2 decimal places. The DBU number is almost never useful to anyone. Same for length in um instead of DBU.

github-actions[bot] commented 2 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

stefanottili commented 2 weeks ago

[INFO GPL-0012] DieAreaLxLy: ( 0.00, 0.00) [INFO GPL-0013] DieAreaUxUy: ( 36.29, 35.84) [INFO GPL-0014] CoreAreaLxLy: ( 1.14, 1.12) [INFO GPL-0015] CoreAreaUxUy: ( 35.15, 34.72) [INFO GPL-0016] CoreArea: 1142.74

1) LxLy ? UxUy ?

I find lb for left bottom and rt for right top much more meaningful.

2) less is more, why not

[INFO GPL-0012] DieArea: ( 0.00 0.00 ) ( 36.29 35.84 ) = … [INFO GPL-0014] CoreArea: ( 1.14 1.12 ) ( 35.15 34.72 ) = 1142.74

3) a space between the number and brackets, no need for a comma. This would make it easier to read for scripting, grep, awk …

gudeh commented 2 weeks ago

[INFO GPL-0012] DieAreaLxLy: ( 0.00, 0.00) [INFO GPL-0013] DieAreaUxUy: ( 36.29, 35.84) [INFO GPL-0014] CoreAreaLxLy: ( 1.14, 1.12) [INFO GPL-0015] CoreAreaUxUy: ( 35.15, 34.72) [INFO GPL-0016] CoreArea: 1142.74

1) LxLy ? UxUy ?

I find lb for left bottom and rt for right top much more meaningful.

2) less is more, why not

[INFO GPL-0012] DieArea: ( 0.00 0.00 ) ( 36.29 35.84 ) = … [INFO GPL-0014] CoreArea: ( 1.14 1.12 ) ( 35.15 34.72 ) = 1142.74

3) a space between the number and brackets, no need for a comma. This would make it easier to read for scripting, grep, awk …

Thanks for the suggestions! I will apply them.

github-actions[bot] commented 1 week ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 1 week ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 1 week ago

clang-tidy review says "All clean, LGTM! :+1:"