search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.35k stars 481 forks source link

Banner cleanup #5031

Closed oharboe closed 2 weeks ago

oharboe commented 2 weeks ago

No conditional code and always print build type.

Before:

Features included (+) or not (-): +Charts +GPU +GUI +Python : RELEASE

After:

Features included (+) or not (-): +Charts +GPU +GUI +Python RELEASE
github-actions[bot] commented 2 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 2 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

maliberty commented 2 weeks ago

I am worried that the word "release" has different meanings. Someone might think this implies it is a formal release rather than a compilation mode. I would like to keep the suppression of that particular string. You could use strcasecmp if that helps.

oharboe commented 2 weeks ago

I am worried that the word "release" has different meanings. Someone might think this implies it is a formal release rather than a compilation mode. I would like to keep the suppression of that particular string. You could use strcasecmp if that helps.

Hmm... I think this solves one problem and creates another by adding complexity. Master is currently broken and the behavior is actually what you didn't want...

I'm going to close this PR, because I think it is probably the best way to go about this, all told, but if something else is wanted, that's more a question of policy than coding...