search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.35k stars 481 forks source link

Dpl more type changes (GridPt & DbuPt) #5039

Closed openroad-robot closed 2 weeks ago

QuantamHD commented 2 weeks ago

Might be a bit late for this, but Boost Units might be a good thing to look at for future unit needs. https://www.boost.org/doc/libs/1_60_0/doc/html/boost_units/Units.html#boost_units.Units.base_units

github-actions[bot] commented 2 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

maliberty commented 2 weeks ago

Might be a bit late for this, but Boost Units might be a good thing to look at for future unit needs. https://www.boost.org/doc/libs/1_60_0/doc/html/boost_units/Units.html#boost_units.Units.base_units

A good thought but it doesn't apply here as the conversion from grid to pixel is variable when you have hybrid rows.