The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.38k stars 485 forks source link

Adding Timing::makeEquivCells and Timing::equivCells Python APIs #5055

Closed bingyuew closed 2 weeks ago

bingyuew commented 3 weeks ago

adding void Timing::makeEquivCells() and std::vector<odb::dbMaster> Timing::equivCells(odb::dbMaster master) Python APIs in the src/Timing.cc file

maliberty commented 3 weeks ago

You have missed the DCO. Please see the directions on the Details like to fix that.

maliberty commented 3 weeks ago

You need to run clang-format as well

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

bingyuew commented 3 weeks ago

Fix the clang-format issue and add sign-offs to each commit.

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"