search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.41k stars 494 forks source link

CI for no differences in .ok file #5214

Open rovinski opened 2 weeks ago

rovinski commented 2 weeks ago

Description

As a simple sanity check, there could be a CI test that any modified .ok files do not have differences in them. This will ensure that they don't get missed on review.

Suggested Solution

A simple script which greps for "Differences found at line" should suffice.

Additional Context

No response

maliberty commented 2 weeks ago

@vvbandeira could this be a GH action?

vvbandeira commented 2 weeks ago

@vvbandeira could this be a GH action?

I think Jenkins should be fine. It would be a simple grep "Differences found at line" **/*.ok or for f in **/*.ok; do ... plus some minor parsing/substitutions just to print the names of the tests in a nice format.