search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.41k stars 494 forks source link

Error in finding logically equivalent cells in OpenSTA using ASAP7 #5244

Open jaemin0502 opened 1 week ago

jaemin0502 commented 1 week ago

Describe the bug

Error detected while finding the equivalent cells using ASAP7 PDK.

It seems that OpenSTA don't observe that "O2A1O1Ixp5_ASAP7_75t_R" and "O2A1O1Ixp33_ASAP7_75t_R" are logically equivalent.

Expected Behavior

They should be considered logically equivalent cells. I can see the same functions as show below.

function : "(!A1 !A2 !C) + (!B !C)"; function : "(!A1 !A2 !C) + (!B !C)";

Environment

[WARNING] Your current OpenROAD version is outdated.
It is recommened to pull the latest changes.
If problem persists, file a github issue with the re-producible test case.
kernel: Linux 3.10.0-1160.118.1.el7.x86_64
os: CentOS Linux 7 (Core)
cmake version 3.25.1
-- The CXX compiler identification is GNU 9.3.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /home/tool/gcc/gcc-9.3.0/bin/x86_64-pc-linux-gnu-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- OpenROAD version: v2.0-13992-g38a3b37
-- System name: Linux
-- Compiler: GNU 9.3.0
-- Build type: RELEASE
-- Install prefix: /usr/local
-- C++ Standard: 17
-- C++ Standard Required: ON
-- C++ Extensions: OFF
-- The C compiler identification is GNU 9.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /home/tool/gcc/gcc-9.3.0/bin/x86_64-pc-linux-gnu-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found Python: /usr/bin/python3.6 (found version "3.6.8") found components: Interpreter 
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE  
-- Performing Test C_COMPILER_SUPPORTS__-Wall
-- Performing Test C_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive - Success
-- Performing Test C_COMPILER_SUPPORTS__-x
-- Performing Test C_COMPILER_SUPPORTS__-x - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-x
-- Performing Test CXX_COMPILER_SUPPORTS__-x - Failed
-- Performing Test C_COMPILER_SUPPORTS__c++
-- Performing Test C_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__c++
-- Performing Test CXX_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- Performing Test C_COMPILER_SUPPORTS__-std=c++17
-- Performing Test C_COMPILER_SUPPORTS__-std=c++17 - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-std=c++17
-- Performing Test CXX_COMPILER_SUPPORTS__-std=c++17 - Success
-- TCL library: /usr/lib64/libtcl.so
-- TCL header: /usr/include/tcl.h
-- Found SWIG: /home/tool/swig/install/4.0.0/bin/swig (found suitable version "4.0.0", minimum required is "4.0")  
-- Found Boost: /home/tool/boost/boost_1_81_0/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0")  
-- boost: 1.81.0
-- Found Python3: /usr/include/python3.6m (found version "3.6.8") found components: Development Development.Module Development.Embed 
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.11") 
-- spdlog: 1.8.1
-- Found BISON: /home/tool/bison/install/3.8.2/bin/bison (found version "3.8.2") 
-- Found Doxygen: /home/tool/doxygen/install/1.8.15/bin/doxygen (found version "1.8.15") found components: doxygen missing components: dot
-- STA version: 2.5.0
-- STA git sha: e01d3f163f483f233db00410b6515a767a6ca03b
-- System name: Linux
-- Compiler: GNU 9.3.0
-- Build type: RELEASE
-- Build CXX_FLAGS: -O3 -DNDEBUG
-- Install prefix: /usr/local
-- Found FLEX: /home/tool/flex/2.6.4/bin/flex (found version "2.6.4") 
-- TCL library: /usr/lib64/libtcl.so
-- TCL header: /usr/include/tcl.h
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- SSTA: 0
-- Found SWIG: /home/tool/swig/install/4.0.0/bin/swig (found suitable version "4.0.0", minimum required is "3.0")  
-- STA executable: /home/jmseo/temp/2024_ICCAD_Contest_Gate_Sizing_Benchmark/OpenROAD/src/sta/app/sta
-- Found re2: /home/tool/ortools/install/CentOS7-gcc9/lib64/cmake/re2/re2Config.cmake (found version "9.0.0") 
-- Found Clp: /home/tool/ortools/install/CentOS7-gcc9/lib64/cmake/Clp/ClpConfig.cmake (found version "1.17.7") 
-- Found Cbc: /home/tool/ortools/install/CentOS7-gcc9/lib64/cmake/Cbc/CbcConfig.cmake (found version "2.10.7") 
-- Found SCIP: /home/tool/ortools/install/CentOS7-gcc9/lib/cmake/scip/scip-config.cmake (found version "8.0.0") 
-- Found OpenMP_CXX: -fopenmp (found version "4.5") 
-- Found OpenMP: TRUE (found version "4.5")  
-- GPU is not enabled
-- TCL library: /usr/lib64/libtcl.so
-- TCL header: /usr/include/tcl.h
-- GUI is enabled
-- Charts widget is not enabled
-- Found Boost: /home/tool/boost/boost_1_81_0/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0") found components: seNumber of processor cores: 8
rialization 
-- Found VTune: /home/tool/intel/vtune_amplifier/lib64/libittnotify.a  
-- Found Boost: /home/tool/boost/boost_1_81_0/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found suitable version "1.81.0", minimum required is "1.78")  
-- TCL library: /usr/lib64/libtcl.so
-- TCL header: /usr/include/tcl.h
-- Found Boost: /home/tool/boost/boost_1_81_0/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0") found components: serialization system thread 
-- Found Boost: /home/tool/boost/boost_1_81_0/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0")  
-- Found Eigen3: /home/tool/ortools/install/CentOS7-gcc9/share/eigen3/cmake/Eigen3Config.cmake (found version "3.4.0") 
-- TCL readline disabled
-- Tcl Extended disabled
-- Python3 enabled
-- Configuring done
-- Generating done
-- Build files have been written to: /dev/shm/tmp.IOEm7FkOPl

To Reproduce

After cloning the github repo below, I ran, "cd 2024_ICCAD_Contest_Gate_Sizing_Benchmark/src/evaluation/ & openroad -python evaluation.py --file_path test.size --design_name NV_NVDLA_partition_m" https://github.com/ASU-VDA-Lab/2024_ICCAD_Contest_Gate_Sizing_Benchmark/tree/main I uploaded test.tcl file in this issue post. (please change the name of the file into test.size)

Relevant log output

No response

Screenshots

Pasted Graphic 9

Additional Context

No response

maliberty commented 1 week ago

I don't see any file test.size (or test.tcl) uploaded here.

maliberty commented 1 week ago

Note: the repo to clone is git@github.com:ASU-VDA-Lab/2024_ICCAD_Contest_Gate_Sizing_Benchmark.git and various files need to be bunzip2'ed.

jaemin0502 commented 1 week ago

test.txt

I uploaded test.txt file and you can change this to test.size.

maliberty commented 1 week ago

Now I get

Error: Instance "FE_PHC4441_csb2cmac_a_req_pvld" not found.

Please make a self-contained test case as this is not efficient.

jaemin0502 commented 1 week ago

I'm sorry but the repo "git@github.com:ASU-VDA-Lab/2024_ICCAD_Contest_Gate_Sizing_Benchmark.git" was committed exactly the day you downloaded the test design and this caused the error you said.

When you want to reproduce the error without downloading the previous code, please simply change the line 1530 of "2024_ICCAD_Contest_Gate_Sizing_Benchmark/design/NV_NVDLA_partition_m/NV_NVDLA_partition_m.size" to "FE_RC_7074_0 O2A1O1Ixp33_ASAP7_75t_R" and run "cd 2024_ICCAD_Contest_Gate_Sizing_Benchmark/src/evaluation/ & openroad -python evaluation.py --file_path ../../design/NV_NVDLA_partition_m/NV_NVDLA_partition_m.size --design_name NV_NVDLA_partition_m"

maliberty commented 1 week ago

sta checks more than the function to determine equivalence. O2A1O1Ixp33_ASAP7_75t_R has 12 timing arcs while O2A1O1Ixp5_ASAP7_75t_R has 11. They are therefore not considered equivalent.

I don't know why they have a different number of arcs. That seems like a library issue.

maliberty commented 1 week ago

The library seems ok but https://github.com/parallaxsw/OpenSTA/discussions/42