maliberty
commented
1 week ago There has to be some coordination between the template and the code. The generator needs to know where to insert the user code. If you look at https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/src/odb/src/codeGenerator/templates/serializer_in.cpp you'll see
//User Code Begin >>{{ comment_tag }}
//User Code End >>{{ comment_tag }}If we allowed arbitrary tag names then how would the generator know where to put the user code within the generated code? In this case the tag name '>>' reflects that it is within operator>>. Another name could be chosen but it needs to be selected at the template level not the user code and must be constant across all uses.
andyfox-rushc
Describe the bug
The database code generator seems to have eccentric behaviour with "tag" names. eg meaningful names like "stmt1" seem to cause the code generator to have problems. For example if in odb/src/db/dbModBTerm.cpp at around line 187 the following User code block is specified:
// User Code Begin stmt1
if (obj.getDatabase()->isSchema(db_schema_db_remove_hash)) { dbDatabase db = (dbDatabase) (obj.getDatabase()); _dbBlock block = (_dbBlock) (db->getChip()->getBlock()); _dbModule* module = block->_module_tbl->getPtr(obj._parent); if (obj._name) { module->_modbterm_hash[obj._name] = obj.getId(); } } // User Code End stmt1
and error is issued. (Exception: User tag stmt1 not used in ../db/dbModBTerm.cpp)
Replace stmt1 with the symbol >> and things work fine.
Doubtless, pilot error, but it would be nice to be able to add meaningful tags to User Code blocks.
Expected Behavior
generator should produce correct c++ code irrespective of name used for tag.
Environment
To Reproduce
For example if in odb/src/db/dbModBTerm.cpp at around line 187 the following User code block is specified:
// User Code Begin stmt1
if (obj.getDatabase()->isSchema(db_schema_db_remove_hash)) { dbDatabase db = (dbDatabase) (obj.getDatabase()); _dbBlock block = (_dbBlock) (db->getChip()->getBlock()); _dbModule* module = block->_module_tbl->getPtr(obj._parent); if (obj._name) { module->_modbterm_hash[obj._name] = obj.getId(); } } // User Code End stmt1
and error is issued. (Exception: User tag stmt1 not used in ../db/dbModBTerm.cpp)
Replace stmt1 with the symbol >> and things work fine.
Relevant log output
No response
Screenshots
No response
Additional Context
No response