search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.64k stars 564 forks source link

gui: use base descriptor class to remove duplicated code for lessThan, makeSelected, and populateODBProps #6022

Closed gadfort closed 1 month ago

gadfort commented 1 month ago

No functional changes expected.

The last time I was adding a ODB descriptor I noticed that I was just copying and pasting the makeSelected, lessThan, and forgot to add the ODB properties to the getProperties.

So this is an attempt to create a base class that can do these things and remove that duplicated code.

maliberty commented 1 month ago

Nice removal of duplicated code. I'll approve once the clang-tidy is cleaned up.

gadfort commented 1 month ago

@maliberty done

github-actions[bot] commented 1 month ago

clang-tidy review says "All clean, LGTM! :+1:"