odb/cdl: Handle top-level pins wired to nets of different name

[smunaut]

ATM the code seem to assume that for each top level pin, the net name is equal to the pin name.

That's not always the case and this produces an incorect netlist.

To solve that, during pin name enumeration when creating the subckt line, we create a mapping from "net name" -> "pin name" for each pin connected to a net of a different name. Then when outputting the connections between sub blocks, we use the pin name instead of the DB net name.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[maliberty]

Please add a unit test that demonstrates this use case.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[maliberty]

I don't see a full test, just

If no ok needs updating it means this change has no effect on any test.

[smunaut]

@maliberty Yes, I changed the input file so that it now triggers the bad behavior. With the new input file and without the code change the resulting CDL would be invalid and not match the ok golden file. With the code fix applied, it generates the same correct netlist as before.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[smunaut]

• Rebased to master
• Implemented the more elegant method above
• Checked that the new test doesn't pass without the patch and passes with the patch.