DRT: Parallelise guides processing

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/

https://theopenroadproject.org/

BSD 3-Clause "New" or "Revised" License

1.62k stars 561 forks source link

Closed openroad-robot closed 1 week ago

openroad-robot commented 3 weeks ago

Removed warnings:

[WARN DRT-1000] Pin {} not in any guide. Attempting to patch guides to cover (at least part of) the pin.
[WARN DRT-0224] {} {} pin not visited, number of guides = {}.
[WARN DRT-0225] {} {} pin not visited, fall back to feedthrough mode.

maliberty commented 3 weeks ago

Are the removed warnings no longer relevant? Its not clear why parallelization would affect them.

maliberty commented 3 weeks ago

The code looks fine aside from the above question

osamahammad21 commented 2 weeks ago

Warning 224 is always followed by an error as it indicates that one of the pins is unreachable. So it's not needed.
Warning 225 is not user friendly. There is nothing wrong with feedthrough mode and it caused this issue with one of the users https://github.com/The-OpenROAD-Project/OpenROAD/issues/5554
Warning 1000 is very frequent. I don't like having such a frequent log message with parallelization.