search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.64k stars 564 forks source link

gui: dont check hidden children states when toggling parent checkbox #6126

Closed gadfort closed 2 weeks ago

gadfort commented 2 weeks ago

I noticed this when debugging https://github.com/The-OpenROAD-Project/OpenROAD/pull/6121.

Before the layers checkbox would be partially filled in (even though all visible boxes are checked): Pasted image

After the layers checkbox is behaving correctly: Pasted image (2)

github-actions[bot] commented 2 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

gadfort commented 2 weeks ago

When do we have hidden rows?

When a technology doesn't have overlay and implant layers, those rows are hidden from view.