The-OpenROAD-Project / OpenSTA

OpenSTA engine
GNU General Public License v3.0
404 stars 173 forks source link

set_clock_uncertainty -rise -fall #104

Closed Chopper455 closed 2 years ago

Chopper455 commented 2 years ago

Tcl procedure of SDC command set_clock_uncertainty doesn't account -rise and -fall flags for inter-clock constraint (-from and -to). It only checks if they were illegally used for single-target constraint. This causes uncertainty to stick to wrong points.

jjcherry56 commented 2 years ago

-rise_to and -fall_to are an equivalent way to specify the edge that are supported, but I added support for -rise/-fall because they are in the sdc spec despite being redundant

Chopper455 commented 2 years ago

The point is that these flags aren't processed even if user specifies them together with -to arguments.

if { [info exists keys(-to)] } { set to_key "-to" set to_rf "rise_fall" } elseif { [info exists keys(-rise_to)] } { set to_key "-rise_to" set to_rf "rise" } elseif { [info exists keys(-fall_to)] } { set to_key "-fall_to" set to_rf "fall" } else { set to_key "none" }

jjcherry56 commented 2 years ago

look at 1aa348f set_clock_uncertainty -rise -fall parsing

Chopper455 commented 2 years ago

Sorry to have bothered you. Thank you.