The-OpenROAD-Project / OpenSTA

OpenSTA engine
GNU General Public License v3.0
388 stars 168 forks source link

dockerfile has bugs #111

Closed taylor-bsg closed 1 year ago

taylor-bsg commented 1 year ago

https://github.com/The-OpenROAD-Project/OpenSTA/blob/12022edc37acf0370f3686eb4ce05c3490b4a7ce/Dockerfile#L29

Patch below

-# Install any git version > 2.6.5
-RUN yum remove -y git* && yum install -y git224
+# Install any git version > 2.6.5 (MBT: I adjusted these rules)
+RUN yum remove -y git* && yum install -y rh-git227
+RUN rm  -f /usr/bin/git; ln -s /opt/rh/rh-git227/root/bin/git /usr/bin/git
+

 # Install SWIG
 RUN yum remove -y swig \
@@ -60,7 +62,8 @@ WORKDIR /OpenSTA
 RUN mkdir build
 #RUN cd buld && cmake .. -DCUDD=$HOME/cudd
 RUN cd build && cmake ..
-RUN make -j 8
+RUN cd build && make -j 8
jjcherry56 commented 1 year ago

It would make more sense to file a pull request when you have a patch. You can test the update; I steer clear of docker.

taylor-bsg commented 1 year ago

Thanks! Yeah docker is not my favorite. I will submit pull requests in the future...