The-OpenROAD-Project / OpenSTA

OpenSTA engine
GNU General Public License v3.0
407 stars 172 forks source link

multiple report_checks command #19

Closed guannan-git closed 5 years ago

guannan-git commented 5 years ago

Dear developer,

I am trying to report multiple timing paths in different restrictions report_checks -through PIN1 -through PIN2 -through PIN3 report_checks -through PIN4 -through PIN5 -through PIN6 ...

I am stacking multiple report_checks in my command file, but I've got "Search.cc:2669 max tag group index exceeded" and "Segmentation fault" when the number of report_checks is over 7000. I would like to know the proper way to write my command file without getting this error.

Thanks

jjcherry56 commented 5 years ago

I can't respond without a testcase.

On Sunday, March 24, 2019, Guannan Guo notifications@github.com wrote:

Dear developer,

I am trying to report multiple timing paths in different restrictions report_checks -through PIN1 -through PIN2 -through PIN3 report_checks -through PIN4 -through PIN5 -through PIN6 ...

I am stacking multiple report_checks in my command file, but I've got "Search.cc:2669 max tag group index exceeded" and "Segmentation fault" when the number of report_checks is over 7000. I would like to know the proper way to write my command file without getting this error.

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/abk-openroad/OpenSTA/issues/19, or mute the thread https://github.com/notifications/unsubscribe-auth/AhI8lVQ4sxfGKk3MbX7kIjjI2xNGNfzwks5vaEgfgaJpZM4cGBU7 .

guannan-git commented 5 years ago

My bad. This is the command file I used. I get obtain correct results for the previous 7422 queries, but it crashes with the error I mentioned afterwards.

vga_lcd.txt

jjcherry56 commented 5 years ago

A command file is not a test case. A test case is all of the files required to reproduce the bug. It so happens that I have vga_lcd because it is an old tau test case and that seems to be the only data floating around the universities so I was able to reproduce this.

If your goal is to get the results you can insert a "find_timing -full" every 1000 lines to "garbage collect". I did this with a emacs macro. If your goal is to break OpenSTA, congratulations. I have some recycling to attend to.

On Sunday, March 24, 2019, Guannan Guo notifications@github.com wrote:

My bad. This is the command file I used. I get obtain correct results for the previous 7422 queries, but it crashes with the error I mentioned afterwards.

vga_lcd.txt https://github.com/abk-openroad/OpenSTA/files/3001785/vga_lcd.txt

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/abk-openroad/OpenSTA/issues/19#issuecomment-476067619, or mute the thread https://github.com/notifications/unsubscribe-auth/AhI8lVo3aqZ_q_gjLIsoXzSxNiMg1BM-ks5vaGjkgaJpZM4cGBU7 .

guannan-git commented 5 years ago

Thanks! This is exactly what I needed. It runs smoothly right now. I have another question to ask. I am wondering if changing the number of threads when I ran OpenSTA will improve the performance for this sort of workload.

jjcherry56 commented 5 years ago

threads will help, but won't fix the underlying problem, which is cleaning up the garbage left by report -from/-thru/-to. I'll get to it but not today.

On Monday, March 25, 2019, Guannan Guo notifications@github.com wrote:

Thanks! This is exactly what I needed. It runs smoothly right now. I have another question to ask. I am wondering if changing the number of threads when I ran OpenSTA will improve the performance for this sort of workload.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/abk-openroad/OpenSTA/issues/19#issuecomment-476481095, or mute the thread https://github.com/notifications/unsubscribe-auth/AhI8lWH1knxURyMaxKZNFpaoeiGn1hNeks5vabA4gaJpZM4cGBU7 .

guannan-git commented 5 years ago

It's good for me as long as I can obtain the results. Thanks again for your answers.

jjcherry56 commented 5 years ago

I pushed a fix so you don't need to modify your scripts.

On Monday, March 25, 2019, Guannan Guo notifications@github.com wrote:

Closed #19 https://github.com/abk-openroad/OpenSTA/issues/19.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/abk-openroad/OpenSTA/issues/19#event-2228601689, or mute the thread https://github.com/notifications/unsubscribe-auth/AhI8lQ9B88L95QQTDUSu1LulJdaIiTrmks5vabJTgaJpZM4cGBU7 .

jjcherry56 commented 5 years ago

I am curious what the point of 46,000 timing reports is.

On Tuesday, March 26, 2019, James Cherry cherry@parallaxsw.com wrote:

I pushed a fix so you don't need to modify your scripts.

On Monday, March 25, 2019, Guannan Guo notifications@github.com wrote:

Closed #19 https://github.com/abk-openroad/OpenSTA/issues/19.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/abk-openroad/OpenSTA/issues/19#event-2228601689, or mute the thread https://github.com/notifications/unsubscribe-auth/AhI8lQ9B88L95QQTDUSu1LulJdaIiTrmks5vabJTgaJpZM4cGBU7 .

guannan-git commented 5 years ago

It's from the TAU 2018 contest. I think they did it for the contest purpose.