search

The-OpenROAD-Project / OpenSTA

OpenSTA engine
GNU General Public License v3.0
399 stars 172 forks source link

Missing util/StaConfig.hh in install file list #21

Closed just22 closed 5 years ago

just22 commented 5 years ago

Hello,

trying to build a port which uses the OpenSTA API (TritonSizer), I noticed that the header file util/StaConfig.hh is missing in the list of files to be installed (this breaks the code in multiple places).

I solved with the following simple patch:

Index: CMakeLists.txt
--- CMakeLists.txt.orig
+++ CMakeLists.txt
@@ -366,6 +366,7 @@ set(STA_HEADERS
   util/ReportStd.hh
   util/ReportTcl.hh
   util/Set.hh
+  util/StaConfig.hh
   util/Stats.hh
   util/StringSeq.hh
   util/StringSet.hh
jjcherry56 commented 5 years ago

looks good to me. I pushed the change to github.

On Thursday, March 28, 2019, Alessandro DE LAURENZIS < notifications@github.com> wrote:

Hello,

trying to build a port which uses the OpenSTA API (TritonSizer), I noticed that the header file util/StaConfig.hh is missing in the list of files to be installed (this breaks the code in multiple places).

I solved with the following simple patch:

Index: CMakeLists.txt --- CMakeLists.txt.orig +++ CMakeLists.txt @@ -366,6 +366,7 @@ set(STA_HEADERS util/ReportStd.hh util/ReportTcl.hh util/Set.hh

  • util/StaConfig.hh util/Stats.hh util/StringSeq.hh util/StringSet.hh

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/abk-openroad/OpenSTA/issues/21, or mute the thread https://github.com/notifications/unsubscribe-auth/AhI8lUSqDjk79Y7DciYuB6cjzleeLIJQks5vbPe6gaJpZM4cQr8P .

just22 commented 5 years ago

Hello James,

thanks. But now the copyright notice in CMakeLists.txt is the wrong one...

-- Alessandro

jjcherry56 commented 5 years ago

ok, try again

On Thursday, March 28, 2019, Alessandro DE LAURENZIS < notifications@github.com> wrote:

Hello James,

thanks. But now the copyright notice in CMakeLists.txt is the wrong one...

-- Alessandro

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/abk-openroad/OpenSTA/issues/21#issuecomment-477882111, or mute the thread https://github.com/notifications/unsubscribe-auth/AhI8lfCYE7LKSSg5mWtvz4VmTQ6LxEApks5vba_5gaJpZM4cQr8P .

just22 commented 5 years ago

Thanks James, problem solved. Closing.