search

The-OpenROAD-Project / OpenSTA

OpenSTA engine
GNU General Public License v3.0
399 stars 172 forks source link

Crash when issuing report_power #26

Closed byzantic closed 5 years ago

byzantic commented 5 years ago

OpenSTA crashes (segfault) when issuing report_power

The behaviour varies with the commit version. It occurs with commit e2dd765b9b4ba091db65291a54f6ed92f4a2603f, (as at 21/06/2019)

does not occur with a version I downloaded from master.zip on 18/06/19

does occur with a version from around (25/05/19)

does not occur with a version from around (29/01/19)

.. all the various versions are due to the fact that I am using docker images, and when building a docker image for other platforms, I pull the master.zip file from github (I should probably rethink my strategy!)

I'm having a problem pinning the versions down to a specific commit - is the commit number in a string anywhere in the code?

jjcherry56 commented 5 years ago

The specific version doesn't matter; I'm sure the head will crash based on what I see here. More important is either a back trace (which is probably not something you can do if you are using docker images because you need to recompile with CMAKE_BUILD_TYPE=DEBUG), or a testcase which reproduces the crash. I can kind of guess what is going on but I think it depends on specific pins missing on instances with specific internal power groups in the liberty.

I doubt if you can see git hashes if you use zip files to get the sources. Is there some reason you don't just clone the repo and use pulls to build the docker images so you know where the came from?

On Fri, Jun 21, 2019 at 6:03 AM byzantic notifications@github.com wrote:

OpenSTA crashes (segfault) when issuing report_power

The behaviour varies with the commit version. It occurs with commit e2dd765 https://github.com/The-OpenROAD-Project/OpenSTA/commit/e2dd765b9b4ba091db65291a54f6ed92f4a2603f, (as at 21/06/2019)

does not occur with a version I downloaded from master.zip on 18/06/19

does occur with a version from around (25/05/19)

does not occur with a version from around (29/01/19)

.. all the various versions are due to the fact that I am using docker images, and when building a docker image for other platforms, I pull the master.zip file from github (I should probably rethink my strategy!)

I'm having a problem pinning the versions down to a specific commit - is the commit number in a string anywhere in the code?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/The-OpenROAD-Project/OpenSTA/issues/26?email_source=notifications&email_token=AIJDZFNDJWMLWYYGQYH76NDP3TGT3A5CNFSM4H2RQBYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G26UUEQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AIJDZFMIB4FEWWT2IBLNMU3P3TGT3ANCNFSM4H2RQBYA .

byzantic commented 5 years ago

Well, I nuke the source tree after building to reduce image size, so actually there's no record of the original code anyway. If I clone from git, but then delete it, that has the same effect..

But I'll have to rethink that strategy. I could clone from git, then squirrel away the hash using something like git rev-parse --short HEAD > versionfile.txt

jjcherry56 commented 5 years ago

If it doesn't crash with the latest version I consider it fixed.

byzantic commented 5 years ago

.. sounds great .. err can't test it until tomorrow (GMT), but I'll let you know asap!

On Mon, 24 Jun 2019, 20:07 James Cherry, notifications@github.com wrote:

If it doesn't crash with the latest version I consider it fixed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/The-OpenROAD-Project/OpenSTA/issues/26?email_source=notifications&email_token=AHDAT3NL3HSBMLJAJ6KNIBLP4ELQZA5CNFSM4H2RQBYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYN5EMQ#issuecomment-505139762, or mute the thread https://github.com/notifications/unsubscribe-auth/AHDAT3KAQR3M3JR5LTK23GTP4ELQZANCNFSM4H2RQBYA .