The-OpenROAD-Project / OpenSTA

OpenSTA engine
GNU General Public License v3.0
399 stars 172 forks source link

TCL_HEADER not included in CMakeList.txt includes #38

Closed andyfox-rushc closed 4 years ago

andyfox-rushc commented 4 years ago

cmake option -DTCL_HEADER would appear not to be working because TCL_HEADER not included in STA_INCLUDE_DIRS in CMakeLists.txt. Possible fix in CMakeLists.txt is:

set(STA_INCLUDE_DIRS app dcalc graph liberty network parasitics sdc sdf search util verilog ${CUDD_INCLUDE}

Add Tcl header..

${TCL_HEADER}
)

jjcherry56 commented 4 years ago

The README.md needs to be updated to reflect a recent change to the cmake file. You want to set TCL_INCLUDE_PATH instead (look further down the file).

On Wed, Jan 15, 2020 at 2:55 PM andy fox notifications@github.com wrote:

cmake option -DTCL_HEADER would appear not to be working because TCL_HEADER not included in STA_INCLUDE_DIRS in CMakeLists.txt. Possible fix in CMakeLists.txt is:

set(STA_INCLUDE_DIRS app dcalc graph liberty network parasitics sdc sdf search util verilog ${CUDD_INCLUDE}

Add Tcl header..

${TCL_HEADER} )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/The-OpenROAD-Project/OpenSTA/issues/38?email_source=notifications&email_token=AIJDZFJ6CELK33YDHQL5IBTQ56A5DA5CNFSM4KHKPNRKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IGPHG4Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJDZFPC4ECAQQOOQFVFGXTQ56A5DANCNFSM4KHKPNRA .

jjcherry56 commented 4 years ago

hold on, that's not right. definitely should not be adding it to STA_INCLUDE_DIRS but it isn't respecting it as an option (it usually just works so I don't pay attention to the broken case)

jjcherry56 commented 4 years ago

Ok, I don't see a problem after trying it. Can you be more specific about the problem and less specific about your proposed fix?