search

The-OpenROAD-Project / OpenSTA

OpenSTA engine
GNU General Public License v3.0
399 stars 172 forks source link

Please consider moving headers into a subdirectory #42

Closed yurivict closed 4 years ago

yurivict commented 4 years ago

The project installs 164 files into /usr/local/include. It's better if they would go into a dedicated subdirectory, for example /usr/local/include/opensta. Fewer files would be in include/, and the possibility of conflicts with other packages would also be lower.

jjcherry56 commented 4 years ago

good idea. nobody really uses make install, but that makes sense. I'm convinced the library or headers even belong in the install target. 950b7c3 master origin/master mv install headers in /opensta, missing headers

yurivict commented 4 years ago

nobody really uses make install

The Arch Linux package uses make install: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=opensta-git

The FreeBSD package also uses make install.

I'm sure all other packages use it too: https://repology.org/project/opensta/versions

jjcherry56 commented 4 years ago

I mean actual code users, not generic package installers. 20 years of users pre-github and I doubt they ever used make install.

On Mon, Mar 23, 2020 at 3:42 PM yuri@FreeBSD notifications@github.com wrote:

nobody really uses make install

The Arch Linux packages uses make install: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=opensta-git

The FreeBSD package also uses make install.

I'm sure all other packages too: https://repology.org/project/opensta/versions

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/The-OpenROAD-Project/OpenSTA/issues/42#issuecomment-602895641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJDZFO5V3UIOUTGWJT73L3RI7QTRANCNFSM4LRWH7IA .

yurivict commented 4 years ago

Yes, users are supposed to install software through packages these days, and packages use make install.