The-OpenROAD-Project / OpenSTA

OpenSTA engine
GNU General Public License v3.0
389 stars 170 forks source link

Missing checkSlewLimitPreamble #46

Closed ahmed-agiza closed 4 years ago

ahmed-agiza commented 4 years ago

Minor issue, missing checkSlewLimitPreamble() at *Sta::checkSlew(const Pin pin,..) causes Segfault if called before any other method that calls checkSlewLimitPreamble();**

jjcherry56 commented 4 years ago

That is intentional. See the comment in Sta.hh It doesn't make sense to call it for every pin.

On Mon, Jun 15, 2020 at 11:20 AM Ahmed Agiza notifications@github.com wrote:

Minor issue, missing checkSlewLimitPreamble() at *Sta::checkSlew(const Pin pin,..) causes Segfault if called before any other method that calls checkSlewLimitPreamble();

You can view, comment on, or merge this pull request online at:

https://github.com/The-OpenROAD-Project/OpenSTA/pull/46 Commit Summary

  • Missing checkSlewLimitPreamble

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/The-OpenROAD-Project/OpenSTA/pull/46, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJDZFKCF744U6HHGC4FHYDRWZRAVANCNFSM4N6NO5LA .