add custom errors

[YouStillAlive]

closes #23

[github-actions[bot]]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

• uninitialized-local (1 results) (Medium)
• unused-return (1 results) (Medium)
• calls-loop (2 results) (Low)
• reentrancy-benign (1 results) (Low)
• reentrancy-events (1 results) (Low)
• timestamp (5 results) (Low)
• naming-convention (13 results) (Informational)
• immutable-states (3 results) (Optimization)

  uninitialized-local

  Impact: Medium Confidence: Medium

• [ ] ID-0 LockDealNFTInternal._split(uint256,address,uint256,address).locals is a local variable never initialized

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/LockDealNFT/LockDealNFTInternal.sol#L121

unused-return

Impact: Medium Confidence: Medium

• [ ] ID-1 LockDealNFT.mintAndTransfer(address,address,uint256,IProvider) ignores return value by IERC20(token).approve(address(vaultManager),amount)

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/LockDealNFT/LockDealNFT.sol#L25-L42

calls-loop

Impact: Low Confidence: Medium

• [ ] ID-2 LockDealNFTState._getData(uint256) has external calls inside a loop: poolInfo = BasePoolInfo(provider,provider.name(),poolId,poolIdToVaultId[poolId],ownerOf(poolId),tokenOf(poolId),provider.getParams(poolId))

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/LockDealNFT/LockDealNFTState.sol#L43-L54

• [ ] ID-3 LockDealNFTState.tokenOf(uint256) has external calls inside a loop: token = vaultManager.vaultIdToTokenAddress(poolIdToVaultId[poolId])

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/LockDealNFT/LockDealNFTState.sol#L80-L82

reentrancy-benign

Impact: Low Confidence: Medium

• [ ] ID-4 Reentrancy in DispenserInternal._handleSimpleNFTs(uint256,address,IDispenserProvider.Builder[]): External calls:
  • amountTaken += _nftIterator(tokenPoolId,owner,data[i])
    • poolId = lockDealNFT.mintForProvider(owner,data.simpleProvider)
    • lockDealNFT.safeTransferFrom(owner,address(lockDealNFT),poolId)
    • data.simpleProvider.registerPool(poolId,data.params)
    • lockDealNFT.cloneVaultId(poolId,tokenPoolId) State variables written after the call(s):
  • _finalizeDeal(tokenPoolId,owner,amountTaken)
    • isTaken[tokenPoolId][owner] = true
  • _finalizeDeal(tokenPoolId,owner,amountTaken)
    • poolIdToAmount[tokenPoolId] -= amountTaken

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/contracts/DispenserInternal.sol#L26-L35

reentrancy-events

Impact: Low Confidence: Medium

• [ ] ID-5 Reentrancy in DispenserProvider.dispenseLock(uint256,uint256,address,IDispenserProvider.Builder[],bytes): External calls:
  • amountTaken = _handleSimpleNFTs(poolId,owner,data)
    • poolId = lockDealNFT.mintForProvider(owner,data.simpleProvider)
    • data.simpleProvider.registerPool(poolId,data.params)
    • lockDealNFT.safeTransferFrom(owner,address(lockDealNFT),poolId)
    • lockDealNFT.cloneVaultId(poolId,tokenPoolId) Event emitted after the call(s):
  • TokensDispensed(poolId,owner,amountTaken,poolIdToAmount[poolId])

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/contracts/DispenserProvider.sol#L11-L27

timestamp

Impact: Low Confidence: Medium

• [ ] ID-6 TimedDealProvider.getWithdrawableAmount(uint256) uses timestamp for comparisons Dangerous comparisons:
  • block.timestamp < startTime
  • finishTime <= block.timestamp

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/SimpleProviders/TimedDealProvider/TimedDealProvider.sol#L31-L45

• [ ] ID-7 DispenserReverts._isValidTime(uint256) uses timestamp for comparisons Dangerous comparisons:
  • validUntil < block.timestamp

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/contracts/DispenserReverts.sol#L17-L21

• [ ] ID-8 LockDealNFTInternal._update(address,uint256,address) uses timestamp for comparisons Dangerous comparisons:
  • require(bool,string)(vaultManager.vaultIdToTradeStartTime(poolIdToVaultId[poolId]) < block.timestamp,Can't transfer before trade start time)

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/LockDealNFT/LockDealNFTInternal.sol#L11-L28

• [ ] ID-9 LockDealProvider.getWithdrawableAmount(uint256) uses timestamp for comparisons Dangerous comparisons:
  • poolIdToTime[poolId] <= block.timestamp

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/SimpleProviders/LockProvider/LockDealProvider.sol#L56-L58

• [ ] ID-10 LockDealProvider._registerPool(uint256,uint256[]) uses timestamp for comparisons Dangerous comparisons:
  • require(bool,string)(block.timestamp <= params[1],Invalid start time)

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/SimpleProviders/LockProvider/LockDealProvider.sol#L39-L44

naming-convention

Impact: Informational Confidence: High

• [ ] ID-11 Function ERC20Token.FreeTest() is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/token/ERC20Token.sol#L22-L24

• [ ] ID-12 Parameter Array.KeepNElementsInArray(uint256[],uint256)._n is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L11

• [ ] ID-13 Parameter Array.KeepNElementsInArray(address[],uint256)._arr is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L25

• [ ] ID-14 Parameter Array.addIfNotExsist(address[],address)._elem is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L81

• [ ] ID-15 Parameter Array.addIfNotExsist(address[],address)._arr is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L81

• [ ] ID-16 Function Array.KeepNElementsInArray(address[],uint256) is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L25-L37

• [ ] ID-17 Function Array.KeepNElementsInArray(uint256[],uint256) is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L11-L23

• [ ] ID-18 Parameter Array.KeepNElementsInArray(address[],uint256)._n is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L25

• [ ] ID-19 Parameter Array.isInArray(address[],address)._elem is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L70

• [ ] ID-20 Parameter Array.KeepNElementsInArray(uint256[],uint256)._arr is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L11

• [ ] ID-21 Parameter Array.getArraySum(uint256[])._array is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L57

• [ ] ID-22 Parameter Array.isArrayOrdered(uint256[])._arr is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L40

• [ ] ID-23 Parameter Array.isInArray(address[],address)._arr is not in mixedCase

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/poolz-helper-v2/contracts/Array.sol#L70

immutable-states

Impact: Optimization Confidence: High

• [ ] ID-24 ProviderState.lockDealNFT should be immutable

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/SimpleProviders/Provider/ProviderState.sol#L9

• [ ] ID-25 LockDealState.provider should be immutable

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/SimpleProviders/LockProvider/LockDealState.sol#L9

• [ ] ID-26 LockDealNFTState.vaultManager should be immutable

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/ff7746df92dc2bf24ec7e3112511fc302e9cd59c/node_modules/@poolzfinance/lockdeal-nft/contracts/LockDealNFT/LockDealNFTState.sol#L18