add gas tracking support, migrate ethers-v5 to v6

[YouStillAlive]

closes #27 closes #28

[github-actions[bot]]

Methods

Symbol	Meaning
◯	Execution gas for this method does not include intrinsic gas overhead
△	Cost was non-zero but below the precision setting for the currency display (see options)

	Min	Max	Avg	Calls	usd avg
DispenserProvider
createNewPool(address[],uint256[],bytes)	296,741	325,041	323,272	16	0.19
dispenseLock(uint256,uint256,address,(address,uint256[])[],bytes)	340,044	352,175	346,922	9	0.20
ERC20Token
approve(address,uint256)	-	-	46,371	16	0.03
LockDealNFT
approve(address,uint256)	-	-	48,730	1	0.03
setApprovalForAll(address,bool)	24,287	46,199	38,895	3	0.02
setApprovedContract(address,bool)	47,960	47,972	47,969	4	0.03

Deployments

	Min	Max	Avg	Block %	usd avg
DealProvider	-	-	2,182,205	1.7 %	1.27
DispenserProvider	-	-	3,047,980	2.3 %	1.77
ERC20Token	-	-	672,901	0.5 %	0.39
LockDealNFT	-	-	5,458,548	4.2 %	3.18
LockDealProvider	-	-	2,322,398	1.8 %	1.35
MockVaultManager	-	-	375,810	0.3 %	0.22
TimedDealProvider	-	-	2,568,915	2 %	1.50

Solidity and Network Config

Settings	Value
Solidity: version	0.8.27
Solidity: optimized	true
Solidity: runs	200
Solidity: viaIR	false
Block Limit	130,000,000
L1 Gas Price	1 gwei
Token Price	582.01 usd/bnb
Network	BINANCE
Toolchain	hardhat

[github-actions[bot]]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

• reentrancy-benign (1 results) (Low)
• reentrancy-events (1 results) (Low)
• timestamp (1 results) (Low)

  reentrancy-benign

  Impact: Low Confidence: Medium

• [ ] ID-0 Reentrancy in DispenserInternal._handleSimpleNFTs(uint256,address,IDispenserProvider.Builder[]): External calls:
  • amountTaken += _nftIterator(tokenPoolId,owner,data[i])
    • poolId = lockDealNFT.mintForProvider(owner,data.simpleProvider)
    • lockDealNFT.safeTransferFrom(owner,address(lockDealNFT),poolId)
    • data.simpleProvider.registerPool(poolId,data.params)
    • lockDealNFT.cloneVaultId(poolId,tokenPoolId) State variables written after the call(s):
  • _finalizeDeal(tokenPoolId,owner,amountTaken)
    • isTaken[tokenPoolId][owner] = true
  • _finalizeDeal(tokenPoolId,owner,amountTaken)
    • poolIdToAmount[tokenPoolId] -= amountTaken

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/676dd734f1cf0950e46dded2150b93b08788d3fb/contracts/DispenserInternal.sol#L43-L52

reentrancy-events

Impact: Low Confidence: Medium

• [ ] ID-1 Reentrancy in DispenserProvider.dispenseLock(uint256,uint256,address,IDispenserProvider.Builder[],bytes): External calls:
  • amountTaken = _handleSimpleNFTs(poolId,owner,data)
    • poolId = lockDealNFT.mintForProvider(owner,data.simpleProvider)
    • data.simpleProvider.registerPool(poolId,data.params)
    • lockDealNFT.safeTransferFrom(owner,address(lockDealNFT),poolId)
    • lockDealNFT.cloneVaultId(poolId,tokenPoolId) Event emitted after the call(s):
  • TokensDispensed(poolId,owner,amountTaken,poolIdToAmount[poolId])

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/676dd734f1cf0950e46dded2150b93b08788d3fb/contracts/DispenserProvider.sol#L24-L44

timestamp

Impact: Low Confidence: Medium

• [ ] ID-2 DispenserReverts._isValidTime(uint256) uses timestamp for comparisons Dangerous comparisons:
  • validUntil < block.timestamp

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/676dd734f1cf0950e46dded2150b93b08788d3fb/contracts/DispenserReverts.sol#L28-L32