`_withdrawIfAvailable` refactor

[YouStillAlive]

closes #26

[github-actions[bot]]

Methods

Symbol	Meaning
◯	Execution gas for this method does not include intrinsic gas overhead
△	Cost was non-zero but below the precision setting for the currency display (see options)

	Min	Max	Avg	Calls	usd avg
DispenserProvider
createNewPool(address[],uint256[],bytes)	294,640	322,940	321,171	16	0.20
dispenseLock(uint256,uint256,address,(address,uint256[])[],bytes)	340,816	353,266	347,377	9	0.22
ERC20Token
approve(address,uint256)	-	-	45,962	16	0.03
LockDealNFT
approve(address,uint256)	-	-	48,353	1	0.03
setApprovalForAll(address,bool)	24,828	46,740	39,436	3	0.03
setApprovedContract(address,bool)	48,143	48,155	48,152	4	0.03

Deployments

	Min	Max	Avg	Block %	usd avg
DealProvider	-	-	1,558,658	1.2 %	0.99
DispenserProvider	-	-	2,214,958	1.7 %	1.41
ERC20Token	-	-	648,905	0.5 %	0.41
LockDealNFT	-	-	4,305,889	3.3 %	2.73
LockDealProvider	-	-	1,707,187	1.3 %	1.08
MockVaultManager	-	-	322,429	0.2 %	0.20
TimedDealProvider	-	-	1,854,511	1.4 %	1.18

Solidity and Network Config

Settings	Value
Solidity: version	0.8.28
Solidity: optimized	true
Solidity: runs	200
Solidity: viaIR	true
Block Limit	130,000,000
L1 Gas Price	1 gwei
Token Price	635.15 usd/bnb
Network	BINANCE
Toolchain	hardhat

[github-actions[bot]]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

• reentrancy-benign (1 results) (Low)
• reentrancy-events (1 results) (Low)

  reentrancy-benign

  Impact: Low Confidence: Medium

• [ ] ID-0 Reentrancy in DispenserInternal._handleSimpleNFTs(uint256,address,IDispenserProvider.Builder[]): External calls:
  • amountTaken += _nftIterator(tokenPoolId,owner,data[i])
    • poolId = lockDealNFT.mintForProvider(owner,data.simpleProvider)
    • data.simpleProvider.registerPool(poolId,data.params)
    • lockDealNFT.safeTransferFrom(lockDealNFT.ownerOf(poolId),address(lockDealNFT),poolId)
    • lockDealNFT.cloneVaultId(poolId,tokenPoolId) State variables written after the call(s):
  • _finalizeDeal(tokenPoolId,owner,amountTaken)
    • isTaken[tokenPoolId][owner] = true
  • _finalizeDeal(tokenPoolId,owner,amountTaken)
    • poolIdToAmount[tokenPoolId] -= amountTaken

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/9269bdb9e64d3e8b177a2e831784be2de8e76ff3/contracts/DispenserInternal.sol#L41-L50

reentrancy-events

Impact: Low Confidence: Medium

• [ ] ID-1 Reentrancy in DispenserProvider.dispenseLock(uint256,uint256,address,IDispenserProvider.Builder[],bytes): External calls:
  • amountTaken = _handleSimpleNFTs(poolId,owner,data)
    • poolId = lockDealNFT.mintForProvider(owner,data.simpleProvider)
    • lockDealNFT.safeTransferFrom(lockDealNFT.ownerOf(poolId),address(lockDealNFT),poolId)
    • data.simpleProvider.registerPool(poolId,data.params)
    • lockDealNFT.cloneVaultId(poolId,tokenPoolId) Event emitted after the call(s):
  • TokensDispensed(poolId,owner,amountTaken,poolIdToAmount[poolId])

https://github.com/The-Poolz/LockDealNFT.DispenserProvider/blob/9269bdb9e64d3e8b177a2e831784be2de8e76ff3/contracts/DispenserProvider.sol#L24-L46