The-Strategy-Unit / nhp_evidence_maps

Shiny app: NHP Models of Care evidence map
https://connect.strategyunitwm.nhs.uk/nhp_evidence_map/
Other
1 stars 0 forks source link

Uses sample to have more values per mechanism. #17

Closed O-Mohammed closed 9 months ago

O-Mohammed commented 9 months ago

Fixes my_dataset object not found error

matt-dray commented 9 months ago

Hello, I just tried running the contents of dev/run_dev.R on this branch. Possible bug: golem::document_and_reload() fails to load mod_search.R because it's looking for the non-existent inst/app/data/tmp_data.rds file, which it's attempting to read into the search_data object. Before I go any further, can you commit a fix to prevent this error?

matt-dray commented 9 months ago

In my local copy of your branch I added /inst/app/data/tmp_data.rds and generated data/my_dataset.rds and the app ran, cheers.

However:

O-Mohammed commented 9 months ago

I've just had a look at the ggwaffle warning message, and I've created an issue #18

It seems that there is a warning message in console when app is loaded up, and the same error message where the waffle chart should be. This warning previously appeared when there were not enough total values in a row to generate the waffle chart.

Currently, once a cell is selected this warning message disappears and the chart loads as expected, I've labelled the issue as a bug and I need to look into why it shows this warning when the app starts up considering that no cell should have been selected.

Note: If the user filters down a small enough sample of evidence using the dropdown inputs, then ggwaffle won't be able to create a chart, e.g. if the year 2022 is selected then currently ggwaffle will show the same error and fail to load a chart. In this instance this seems to be a 'limitation' of ggwaffle rather than a bug in the app.

matt-dray commented 9 months ago

Looks like I don't have write access. Are you able to give me admin access to the repo?

O-Mohammed commented 9 months ago

Looks like I don't have write access. Are you able to give me admin access to the repo?

You should now have admin access