The-Strategy-Unit / pxtextmining

Text classification of NHS patient feedback.
https://the-strategy-unit.github.io/pxtextmining/
MIT License
28 stars 8 forks source link

Security fixes 16 17 25 26 #133

Closed yiwen-h closed 1 year ago

yiwen-h commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 56.20% and project coverage change: -5.04% :warning:

Comparison is base (2a23864) 93.39% compared to head (71ece91) 88.36%. Report is 47 commits behind head on development.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #133 +/- ## =============================================== - Coverage 93.39% 88.36% -5.04% =============================================== Files 10 11 +1 Lines 833 937 +104 =============================================== + Hits 778 828 +50 - Misses 55 109 +54 ``` | [Files Changed](https://app.codecov.io/gh/CDU-data-science-team/pxtextmining/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDU-data-science-team) | Coverage Δ | | |---|---|---| | [...xtextmining/factories/factory\_model\_performance.py](https://app.codecov.io/gh/CDU-data-science-team/pxtextmining/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDU-data-science-team#diff-cHh0ZXh0bWluaW5nL2ZhY3Rvcmllcy9mYWN0b3J5X21vZGVsX3BlcmZvcm1hbmNlLnB5) | `77.67% <25.80%> (-20.00%)` | :arrow_down: | | [...ining/factories/factory\_predict\_unlabelled\_text.py](https://app.codecov.io/gh/CDU-data-science-team/pxtextmining/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDU-data-science-team#diff-cHh0ZXh0bWluaW5nL2ZhY3Rvcmllcy9mYWN0b3J5X3ByZWRpY3RfdW5sYWJlbGxlZF90ZXh0LnB5) | `83.52% <45.71%> (-7.76%)` | :arrow_down: | | [pxtextmining/factories/factory\_write\_results.py](https://app.codecov.io/gh/CDU-data-science-team/pxtextmining/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDU-data-science-team#diff-cHh0ZXh0bWluaW5nL2ZhY3Rvcmllcy9mYWN0b3J5X3dyaXRlX3Jlc3VsdHMucHk=) | `76.36% <61.11%> (-5.99%)` | :arrow_down: | | [docker\_run.py](https://app.codecov.io/gh/CDU-data-science-team/pxtextmining/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDU-data-science-team#diff-ZG9ja2VyX3J1bi5weQ==) | `76.59% <76.59%> (ø)` | | | [pxtextmining/pipelines/multilabel\_pipeline.py](https://app.codecov.io/gh/CDU-data-science-team/pxtextmining/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDU-data-science-team#diff-cHh0ZXh0bWluaW5nL3BpcGVsaW5lcy9tdWx0aWxhYmVsX3BpcGVsaW5lLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yiwen-h commented 1 year ago

Can merge regardless of codecov I think. I know, I know, I haven't been keeping up with tests... added more code but didn't add equivalent tests so overall, coverage has dropped leading to the failures above.