The-Toblin / c2d10-foundry-vtt

Celenia D10 RPG System - 2nd Edition
GNU General Public License v3.0
2 stars 0 forks source link

Rolls performed by players do sometimes not obey the DC set by the Keeper #38

Closed The-Toblin closed 1 year ago

The-Toblin commented 1 year ago

Many rolls default to DC2 in spite of a different DC being set by the Keeper. Investigate if this is a coding issue or a lag issue.

The-Toblin commented 1 year ago

Testing indicates this is a latency issue. If the Keeper changes the DC and the player rolls shortly after, the setting hasn't updated by the time the player rolls.

The-Toblin commented 1 year ago

Further testing, using the new roll class, indicates that this should now only happen on extremely poor connections and that's not something that can be solved through code.

Moving the DC check to much later in the roll class, rather than when the button is first clicked, helped a lot with curtailing cases of a player opening the roll dialog (reading the current DC) and the Keeper changing the DC afterwards, but before the player actually clicked "Roll".

Now, the DC is fetched just before displaying the results in the chat, which makes the gap for mistakes much, much smaller, and barring 1000ms+ latency, should never happen again.

Fixed for 0.521.