The-Trust-Assembly / trust-assembly

For SomeGuy's Trust Assembly Project
0 stars 1 forks source link

Figure out repo settings #2

Open adhurjaty opened 19 hours ago

adhurjaty commented 19 hours ago
adhurjaty commented 19 hours ago

Looking at Google's engineering practices. I don't think we have to go full-corporate in terms of commit message formatting etc., but would be good to have some guidelines for contributing.

Do we want branch naming guidelines? @time.e.less had indicated feature_yourname_shortname as his preference, should we stick with that?

I prefer working with atomic commits (no commit leaves the system in a broken state or failing tests)

Merge, rebase, or squash and merge PRs?

@Melvillian @maxtriano do you have opinions on any of these

maxtriano commented 18 hours ago

@adhurjaty No opinion beyond that we squash and merge for PRs to main at my job and I like it, keeps main's history cleaner.

adhurjaty commented 18 hours ago

@adhurjaty No opinion beyond that we squash and merge for PRs to main at my job and I like it, keeps main's history cleaner.

I'm good with committing to that at least for now