The-Virtual-Desktop-Team / Virtual-Desktop-Optimization-Tool

The script and configuration files in this repository provide an easy method to customize and apply performance related settings to virtual desktop environments.
687 stars 174 forks source link

Newest version won't run. "The term 'BEGIN' is not recognized as the name " #100

Closed stashgumbo closed 3 years ago

stashgumbo commented 3 years ago

What am I doing wrong?

PS C:\Optimize> .\Win10_VirtualDesktop_Optimize.ps1 -Verbose BEGIN : The term 'BEGIN' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. At C:\Optimize\Win10_VirtualDesktop_Optimize.ps1:84 char:1

Get-Process : Cannot evaluate parameter 'Name' because its argument is specified as a script block and there is no input. A script block cannot be evaluated without input. At C:\Optimize\Win10_VirtualDesktop_Optimize.ps1:112 char:9

image

tmmuessig commented 3 years ago

Hi @stashgumbo - You are not doing anything wrong. There was some code added to check for 21H2 and it was placed in the wrong place. Please re-download Win10_VirtualDesktop_Optimize.ps1 and you should be good to go.

Let me know if you have any additional issues.

stashgumbo commented 3 years ago

You rock. Thanks for the quick response. Working like a charm now.

tmmuessig commented 3 years ago

Happy to help.. Let us know if you have any more issues.

stashgumbo commented 3 years ago

Quick question. I have an app that is requiring windows media player. Any way to get it back once its been removed by the script or do I need to start again and disable removing WMP.

From: Tim Muessig @.> Sent: Monday, October 18, 2021 10:57 AM To: The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool @.> Cc: Tas Smith @.>; Mention @.> Subject: Re: [The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool] Newest version won't run. "The term 'BEGIN' is not recognized as the name " (Issue #100)

Happy to help.. Let us know if you have any more issues.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool/issues/100#issuecomment-946021320, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWDT25WTYCBPRAMNWD4F7PLUHRNXRANCNFSM5GHGKUIA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

tmmuessig commented 3 years ago

You should be able to run the following on that box that needs Windows Media Player, though I have not 100% tested this so you might have to play around with it a little:

Get-WindowsPackage -Online -PackageName "*Windows-MediaPlayer*" | Add-WindowsPackage -Online