search

The-Virtual-Desktop-Team / Virtual-Desktop-Optimization-Tool

The script and configuration files in this repository provide an easy method to customize and apply performance related settings to virtual desktop environments.
694 stars 173 forks source link

Duplicated registry entries in `PolicyRegSettings.json` #191

Closed aotongarcia closed 9 months ago

aotongarcia commented 9 months ago

In PolicyRegSettings.json, I noticed that at least 3 policies are duplicated and the duplicates are pointing to an incorrect registry path, DisableAcrylicBackgroundOnLogon, DisableLockScreenAppNotifications, and DontEnumerateConnectedUsers.

Correct registry path:

https://github.com/The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool/blob/211628c081e7b59a64d4d6dab1c18bef303e8554/2009/ConfigurationFiles/PolicyRegSettings.json#L94

https://github.com/The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool/blob/211628c081e7b59a64d4d6dab1c18bef303e8554/2009/ConfigurationFiles/PolicyRegSettings.json#L101

https://github.com/The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool/blob/211628c081e7b59a64d4d6dab1c18bef303e8554/2009/ConfigurationFiles/PolicyRegSettings.json#L108

Duplicates & incorrect registry path:

https://github.com/The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool/blob/211628c081e7b59a64d4d6dab1c18bef303e8554/2009/ConfigurationFiles/PolicyRegSettings.json#L353

https://github.com/The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool/blob/211628c081e7b59a64d4d6dab1c18bef303e8554/2009/ConfigurationFiles/PolicyRegSettings.json#L360

https://github.com/The-Virtual-Desktop-Team/Virtual-Desktop-Optimization-Tool/blob/211628c081e7b59a64d4d6dab1c18bef303e8554/2009/ConfigurationFiles/PolicyRegSettings.json#L367

robsmi-msfte commented 9 months ago

I reviewed these and agree. We are reviewing and will most likely approve and push to main. Thanks for reporting this.