search

The-Wineskin-Project / WineskinServer

Wineskin
GNU Lesser General Public License v2.1
2.47k stars 170 forks source link

implementing CreateFileTransactedA #605

Closed rlarhsid closed 2 months ago

rlarhsid commented 2 months ago

Environment (please complete the following information):

OS: macOS 15.0 Sequoia Beta Winery version: v2.0.2 Master Wrapper version: v3.0.6 Engine version: 23.7.1-3_rc1 Hardware: Macbook Pro 14 / M1 Max Application/Game Name: Persona 5: The Royal Render used: D3DMetal with (https://github.com/The-Wineskin-Project/WineskinServer/issues/604) installed

Describe the bug Thanks to your work, the game starts and displays everything correctly. However, there is one more major problem, P5R uses CreateFileTransactedA function for writing save-file, config file and etc. If I'm correct, it seems that this function is not implemented to your wine engines. Trying any functions that I've wrote causes the game to crash without any notice.

To Reproduce

  1. Install Steam with winetricks "steam", "fakekorean", "fakejapanese", and complete this (https://github.com/The-Wineskin-Project/WineskinServer/issues/604).
  2. Install P5R via Steam.
  3. Open the game and do any behaviors that will use the file-writing function (game saving, editing configs, etc).
  4. Game will crash without notice.

Expected behavior CreateFileTransactedA is implemented.

Screenshots

image

Also, I'll add a video about how the game crashes. Watch 1:50 to the end. https://youtu.be/CTkp6y4U57g

LastRunWine.log LastRunWine.log

Additional context On the Linux community (Proton), there is already a patch for this problem. https://github.com/ValveSoftware/Proton/issues/6255#issuecomment-1287977776

Also, the game seems to require AVX/AVX2 support, but guess this isn't a big deal as the game is currently running fine, and only has data wrting issues.

Gcenx commented 2 months ago

Try with WS12WineCX64Bit23.7.1-3_rc2 that includes MR1145 and also the fix from issue 604

Also, the game seems to require AVX/AVX2 support, but guess this isn't a big deal as the game is currently running fine, and only has data wrting issues.

macOS Sequoia Rosetta2 implements AVX/AVX2 so it makes sense, thought it doesn't help for all games.

Gcenx commented 2 months ago

@rlarhsid when you get chance try the above

rlarhsid commented 2 months ago

ah sorry, just read it now. It works without any issues. Thanks again!