search

The0nlyJuan / pe

0 stars 0 forks source link

Duplicate names because of case sensitivity #3

Open The0nlyJuan opened 1 week ago

The0nlyJuan commented 1 week ago

Summary

Duplicate names entered with differing case sensivity is accepted

Expected Behavior: Should be rejected as likely same person

Actual Behavior: Both are added

Steps to Reproduce

  1. Add 2 different buyers with everything same except name, eg. John Doe and john Doe

Screenshots

image.png

Reasoning for Severity

Should not be a big problem unless you have multiple people of the same name but maybe if you adding the same person but use a different case sensitivity users will get duplicate entries

nus-pe-bot commented 1 week ago

Team's Response

The same fix mentioned in future enhancements will fix all these duplicate issues.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate persons can be added (buyer mode)

duplicates.png It is mentioned in the UG that "New buyers must have unique names and must not be duplicate names of existing buyers". However, I can add a buyer with the same name and same details as an existing buyer.

In the real world, buyer names should be case-insensitive and a buyer with name "roy balakrishnan" is likely the same person as "Roy Balakrishnan", so the app should not allow duplicates to be added like this.

[original: nus-cs2103-AY2425S1/pe-interim#1895] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is only an issue when it is the same case-insensitive name and the same phone number for 2 contacts. In our future enhancements in our Developer Guide, we mentioned that we will do checking through phone number or email instead for buyers. This is because 2 people with the same name may exist, and phone numbers and emails are better ways to identify buyers. Hence, in this case, it is not in scope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]