search

The0nlyJuan / pe

0 stars 0 forks source link

Adding of Budget does not allow for spaces in the numbers #6

Open The0nlyJuan opened 1 week ago

The0nlyJuan commented 1 week ago

Summary

Spaces between numbers throws an error.

Expected Behavior: Should still accept numbers with spaces because UG and error messages do not explicitly say its not allowed

Actual Behavior: Invalid input

Steps to Reproduce

  1. add n/Jon Doe p/98765432 e/johnd@example.com b/120 000 t/friends t/owesMoney

  2. Error message thrown

Screenshots

image.png

image.png

Reasoning for Severity

This can be both a feature flaw and functionality bug. Both the error thrown in the application and also the acceptable paramters in the UG has the same message regarding the budget. So when i try to add 120 000, users may expect it to be accpeted as some people type numbers with spaces to see the order of magnitude easily. Both the error message thrown and UG could have be improved if this was the inteded usage or the parser could take in number with spaces as in improvement for this feature. Some users may find these an issue and may hinder their usage so it will be assigned medium severity.

soc-pe-bot commented 4 days ago

Team's Response

This is rejected as it is mentioned in the command instructions that only numbers and commas are accepted as input. Moreover, it is unconventional to use whitespaces when inputting numbers digitally for a budget.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The Dev team said that only number and commas are accepted as input but does not say white spaces are rejected. Also they said that whitespaces is uncoventional to use when putting in numbers for budget. However, I find that there would be a substantial amount of people that would use whitespaces to separate numbers especially when dealing with big numbers such as budget in the case of the dev teams application. I feel that both comma and whitespaces are equally as common as people use whitespaces to better count the number of zeroes in a big number such as 12 000 000 which is also faster than commas. I agree that severity can be downgraded to low because users can still use the comma function but it should not be rejected as a whole.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]