search

The0nlyJuan / pe

0 stars 0 forks source link

Incorrect Error message when extra parameter is entered for adding of meetups #7

Open The0nlyJuan opened 1 week ago

The0nlyJuan commented 1 week ago

Summary

When an extra paramter is added at the end of add meetup, it shows error message for invalid name of buyer. Error not handled correctly

Expected Behavior: The extra paramter should have been picked up as a command format error

Actual Behavior: Invalid name of buy error thrown

Steps to Reproduce

  1. add a meetup with extra parameter at the back
  2. eg. add s/Discuss work plans i/Meet with Jason to discuss the March Project f/2024-02-03 14:00 t/2024-02-03 15:30 n/Alex Yeoh n/David Li p/
  3. Invalid buyer error thrown

Screenshots

image.png

Reasoning for Severity

Medium severity because the error message has nothing to do with the invalid input.

nus-pe-script commented 1 week ago

Team's Response

Rejected since p/ is not part of the prefixes that are accepted for meet-ups. Moreover, the invalid buyer message shown is correct since p/ is considered part of n/ David Li p/ by the parser, and thus "special characters are not allowed".

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]