TheAMM / mpv_thumbnail_script

A Lua script to show preview thumbnails in mpv's OSC seekbar, sans external dependencies
GNU General Public License v3.0
674 stars 67 forks source link

crash similar too #11 on 0.4.2 #34

Open bricewge opened 5 years ago

bricewge commented 5 years ago

It looks like issue #11 but I'm using 0.4.2 so this should have been fixed in that release. It happen when moving between files in a directory with a key bound to the command playlist-prev. Here is the error:

[mpv_thumbnail_script_client_osc]
[mpv_thumbnail_script_client_osc] stack traceback:
[mpv_thumbnail_script_client_osc]       [C]: in function 'max'
[mpv_thumbnail_script_client_osc]       .../.config/mpv/scripts/mpv_thumbnail_script_client_osc.lua:857: in function 'on_thumb_progress'
[mpv_thumbnail_script_client_osc]       .../.config/mpv/scripts/mpv_thumbnail_script_client_osc.lua:1061: in function 'handler'
[mpv_thumbnail_script_client_osc]       mp.defaults:339: in function 'handler'
[mpv_thumbnail_script_client_osc]       mp.defaults:459: in function 'call_event_handlers'
[mpv_thumbnail_script_client_osc]       mp.defaults:496: in function 'dispatch_events'
[mpv_thumbnail_script_client_osc]       mp.defaults:452: in function <mp.defaults:451>
[mpv_thumbnail_script_client_osc]       [C]: in ?
[mpv_thumbnail_script_client_osc]       [C]: in ?
[mpv_thumbnail_script_client_osc] Lua error: .../.config/mpv/scripts/mpv_thumbnail_script_client_osc.lua:857: bad argument #1 to 'max' (number expected, got nil)
     Subs  --sid=1 (subrip)
No video or audio streams selected.
crides commented 4 years ago

I managed to get rid of that by setting osc=no in my mpv config. But I still can't generate the thumbnails due to some other errors.